Issue #896 - Add checking for MIME-type parameter fhirVersion #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbieste
force-pushed
the
tbieste-issue-896
branch
2 times, most recently
from
f944279 to
1cc3a08
Compare
|
Would we want to use 4.0.0 and 4.0.1 as supported versions or is 4.0 sufficient? |
prb112
reviewed
May 27, 2021
prb112
reviewed
May 27, 2021
fhir-server-test/src/test/java/com/ibm/fhir/server/test/BasicServerTest.java
Show resolved
Hide resolved
prb112
reviewed
May 27, 2021
fhir-server/src/main/java/com/ibm/fhir/server/filter/rest/FHIRRestServletFilter.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
May 27, 2021
fhir-server/src/main/java/com/ibm/fhir/server/filter/rest/FHIRRestServletFilter.java
Outdated
Show resolved
Hide resolved
Yeah, I wasn't sure about that, based on https://www.hl7.org/fhir/http.html#version-parameter, it says the value of this parameter is the publication and major version number for the specification. So it sounds like it is not supposed to include the minor version. However, I'll add 4.0.1 to the list since it is consistent with the version shown in the Capabilities statement returned on the |
lmsurpre
reviewed
Jun 2, 2021
fhir-server/src/main/java/com/ibm/fhir/server/filter/rest/FHIRRestServletFilter.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Jun 2, 2021
fhir-server/src/main/java/com/ibm/fhir/server/filter/rest/FHIRRestServletFilter.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Jun 2, 2021
fhir-server/src/main/java/com/ibm/fhir/server/filter/rest/FHIRRestServletFilter.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jun 2, 2021
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
force-pushed
the
tbieste-issue-896
branch
from
7ab015e to
1c93d23
Compare
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
tbieste
force-pushed
the
tbieste-issue-896
branch
from
1c93d23 to
a7e01ae
Compare
tbieste
added a commit
that referenced
this pull request
Jun 9, 2021
Issue #896 - Add checking for MIME-type parameter fhirVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #896 - Add checking for MIME-type parameter fhirVersion
Signed-off-by: Troy Biesterfeld tbieste@us.ibm.com