Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2431 - add support for headers in RemoteTermServiceProvider #2435

Merged
merged 5 commits into from
May 26, 2021

Conversation

JohnTimm
Copy link
Collaborator

Signed-off-by: John T.E. Timm johntimm@us.ibm.com

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm requested a review from prb112 May 26, 2021 19:57
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm requested a review from csandersdev May 26, 2021 20:07
Copy link
Contributor

@csandersdev csandersdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm merged commit 567eff3 into main May 26, 2021
@JohnTimm JohnTimm deleted the johntimm-main branch May 26, 2021 21:31
tbieste pushed a commit that referenced this pull request Jun 9, 2021
…2435)

* Issue #2431 - add support for headers in RemoteTermServiceProvider

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2431 - update docs

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2432 - add dependsOnMethods to annotation

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2431 - minor tweak

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2431 - fix integration test

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants