issue #2143 - support custom compartment types via extension #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmsurpre
commented
May 27, 2021
Comment on lines
2615
to
2624
| if (paramEntry.getValue().size() != 1) { | ||
| log.warning("CompartmentDefinition inclusion criteria must be of type Reference unless they have 1 and only 1 resource target"); | ||
| continue; | ||
| } | ||
| compartmentName = paramEntry.getValue().iterator().next(); | ||
| compartmentId = element.as(FHIR_STRING).getValue(); |
There was a problem hiding this comment.
previously, we supported only inclusion criteria that selected elements of type Reference. now we will support elements of type String as well, but only in cases where the compartment type is unambiguous (so that we do not need to check the target resourceType from the reference to determine which compartment the value is for).
prb112
reviewed
May 27, 2021
fhir-registry/src/main/java/com/ibm/fhir/registry/FHIRRegistry.java
Outdated
Show resolved
Hide resolved
prb112
approved these changes
May 27, 2021
lmsurpre
commented
May 27, 2021
fhir-registry/src/main/java/com/ibm/fhir/registry/resource/FHIRRegistryResource.java
Outdated
Show resolved
Hide resolved
lmsurpre
force-pushed
the
issue-2143-2
branch
2 times, most recently
from
8cc9787 to
240745d
Compare
The CompartmentDefinition resource has a required binding to a fixed list of compartment types. To support a custom compartments, we will now look for the `http://ibm.com/fhir/extension/custom-compartment-type` extension on this element (when it has no value). Additionally, I created a constant in fhir-core FHIRConstants for our base extension url and I updated all the different places we have extension urls to use it. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
tbieste
pushed a commit
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CompartmentDefinition resource has a required binding to a fixed
list of compartment types. To support a custom compartments, we will now
look for the
http://ibm.com/fhir/extension/custom-compartment-typeextension on this element (when it has no value).
Additionally, I created a constant in fhir-core FHIRConstants for our
base extension url and I updated all the different places we have
extension urls to use it.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com