Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2445 - Log warning messages about deprecated tables #2448

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Issue #2445 - Log warning messages about deprecated tables #2448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7920033
Issue #2445 - Log warning messages about deprecated tables
tbieste Jun 1, 2021
3b209c2
Issue #2445 - Update after review comments
tbieste Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/app/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@

import com.ibm.fhir.database.utils.api.DataAccessException;
import com.ibm.fhir.database.utils.api.DatabaseNotReadyException;
import com.ibm.fhir.database.utils.api.UndefinedNameException;
import com.ibm.fhir.database.utils.api.IDatabaseAdapter;
import com.ibm.fhir.database.utils.api.IDatabaseTranslator;
import com.ibm.fhir.database.utils.api.ITransaction;
import com.ibm.fhir.database.utils.api.ITransactionProvider;
import com.ibm.fhir.database.utils.api.TenantStatus;
import com.ibm.fhir.database.utils.api.UndefinedNameException;
import com.ibm.fhir.database.utils.common.DataDefinitionUtil;
import com.ibm.fhir.database.utils.common.JdbcConnectionProvider;
import com.ibm.fhir.database.utils.common.JdbcPropertyAdapter;
Expand Down Expand Up @@ -402,6 +402,10 @@ protected void updateSchema() {

// perform any updates we need related to the V0010 schema change (IS_DELETED flag)
applyDataMigrationForV0010();

// Log warning messages that unused tables will be removed in a future release.
// TODO: This will no longer be needed after the tables are removed (https://github.com/IBM/FHIR/issues/713).
logWarningMessagesForDeprecatedTables();
}

/**
Expand Down Expand Up @@ -1867,6 +1871,20 @@ protected void logStatusMessage(int status) {
}
}

/**
* Log warning messages for deprecated tables.
*/
private void logWarningMessagesForDeprecatedTables() {
List<String> deprecatedTables = Arrays.asList(
"DOMAINRESOURCE_DATE_VALUES", "DOMAINRESOURCE_LATLNG_VALUES", "DOMAINRESOURCE_LOGICAL_RESOURCES", "DOMAINRESOURCE_NUMBER_VALUES",
"DOMAINRESOURCE_QUANTITY_VALUES", "DOMAINRESOURCE_RESOURCE_TOKEN_REFS", "DOMAINRESOURCE_RESOURCES","DOMAINRESOURCE_STR_VALUES",
"RESOURCE_DATE_VALUES", "RESOURCE_LATLNG_VALUES", "RESOURCE_LOGICAL_RESOURCES", "RESOURCE_NUMBER_VALUES",
"RESOURCE_QUANTITY_VALUES", "RESOURCE_RESOURCE_TOKEN_REFS", "RESOURCE_RESOURCES", "RESOURCE_STR_VALUES");
for (String deprecatedTable : deprecatedTables) {
logger.warning("Table '" + deprecatedTable + "' will be dropped in a future release. No data should be written to this table. If any data exists in the table, that data should be deleted.");
}
tbieste marked this conversation as resolved.
Show resolved Hide resolved
}

/**
* Main entry point
*
Expand Down