issue #2510 - make FHIRPathUtil threadsafe #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this a nominal change? e.g. does not impact the benchmark? or is this additive? I'm expecting no impact, but want to confirm in discussion. |
Yes, the blast radius is pretty small on this one. We just avoid using a shared FHIRPathEvaluator. There is a potential for this to slow things down just a bit, but constructing FHIRPathEvaluators should be relatively cheap. If it ends up needing optimization, it would be possible to introduce a ThreadLocal cache, but I don't think it will even register on a profiler. |
FHIRPathUtil was using a shared static FHIRPathEvaluator but this is not thread-safe. Now we construct a new evaluator for each request. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
JohnTimm
approved these changes
Jun 15, 2021
lmsurpre
commented
Jun 15, 2021
| @@ -88,8 +88,6 @@ | |||
| import com.ibm.fhir.path.exception.FHIRPathException; | |||
|
|
|||
| public final class FHIRPathUtil { | |||
| private static FHIRPathEvaluator evaluator = FHIRPathEvaluator.evaluator(); | |||
There was a problem hiding this comment.
this shared FHIRPathEvaluator was the real culprit
prb112
approved these changes
Jun 15, 2021
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FHIRPathUtil was using a shared static FHIRPathEvaluator but this is not
thread-safe. Now we construct a new evaluator for each request.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com