Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2582, #2583 - general refactoring / clean-up #2599

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Conversation

JohnTimm
Copy link
Collaborator

  • Moved validateProfileReferences(...) method from FHIRValidator to FHIRValidator.ValidatingNodeVisitor
  • Updated main FHIRValidator.validate(...) method / entry point to be more consistent with main FHIRPathEvaluator.evaluate(...) method / entry point
  • Updated main FHIRValidator.ValidatingNodeVisitor.validate(...) method to be more consistent with FHIRPathEvaluator.EvaluatingVisitor.evaluate(...) method
  • Updated ValidatingNodeVisitor.validate(FHIRPathElementNode) and ValidatingNodeVisitor.validate(FHIRPathResourceNode) methods to be more consistent in structure

Signed-off-by: John T.E. Timm johntimm@us.ibm.com

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm requested a review from prb112 July 12, 2021 14:35
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm merged commit 3928f09 into main Jul 12, 2021
@JohnTimm JohnTimm deleted the johntimm-main branch July 12, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants