Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fixes #2719

Merged
merged 6 commits into from
Aug 25, 2021
Merged

Minor Fixes #2719

merged 6 commits into from
Aug 25, 2021

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Aug 24, 2021

Signed-off-by: Paul Bastide pbastide@us.ibm.com

- Bulk Export Status #2715
	- Added a default Error
- Bulk Export Status Report #2714
	- Added property for requiresAccessToken
- Composition reports a 500 when it's a bad user request #2717
	- Mutate 500 to 400 in $document
	- Add Test for $document when bad request

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 self-assigned this Aug 24, 2021
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
#2720

- if is patch, we implement skippable.
- Should this go in the conformance doc?

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Copy link
Collaborator

@JohnTimm JohnTimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prb112 prb112 merged commit 3dcac97 into main Aug 25, 2021
@prb112 prb112 deleted the bulkdata-fixes branch August 25, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants