Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fhir-persistence-schema CLI drop schema gives an error #2758 #2775

Merged
merged 6 commits into from
Sep 20, 2021
Merged

Conversation

prb112
Copy link
Contributor

@prb112 prb112 commented Sep 17, 2021

  • Add missing tags to whole system tables to enforce a FK drop prior to
    table drop
  • Add tags to the OAuthSchemaGenerator and JavaBatchGenerator (drop
    wasn't working without the tags)
  • Tags are unique for the Generator

No schema change this is in the runtime of the CLI only.

Signed-off-by: Paul Bastide pbastide@us.ibm.com

- Add missing tags to whole system tables to enforce a FK drop prior to
table drop
- Add tags to the OAuthSchemaGenerator and JavaBatchGenerator (drop
wasn't working without the tags)

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@lmsurpre lmsurpre self-requested a review September 17, 2021 17:48
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@punktilious punktilious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we extend the schema migration test to include a drop phase...then we can check that all the objects have been dropped.

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 merged commit 2e808fd into main Sep 20, 2021
@prb112 prb112 deleted the issue-2758 branch September 20, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants