Issues 2728, 2878, and 2879 - Remove old query builder, update tests, and fix issues #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prb112
approved these changes
Oct 21, 2021
michaelwschroeder
approved these changes
Oct 21, 2021
...rsistence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/impl/FHIRPersistenceJDBCImpl.java
Show resolved
Hide resolved
I also removed the older-style `addXCacheCandidate` methods from the ParameterDAO and ResourceDAO interfaces and reduced their visibility in the implementation classes. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
should be cosine, not arccosine Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
punktilious
reviewed
Oct 22, 2021
Comment on lines
+187
to
197
| for (int i=0; i<expectedBindVariables.size(); i++) { | ||
| Object expectedValue = expectedBindVariables.get(i); | ||
| BindMarkerNode bindMarker = collectBindMarkersInto.get(i); | ||
|
|
||
| if (!bindMarker.checkTypeAndValue(expectedValue)) { | ||
| StringBuilder msg = new StringBuilder(); | ||
| msg.append("BIND[").append(i).append("] ") | ||
| .append("EXPECTED=").append(expectedValue) | ||
| .append("; ACTUAL=").append(bindMarker.toValueString("~")); | ||
| fail(msg.toString()); | ||
| } |
There was a problem hiding this comment.
for sure. and its actually common across multiple tests, but maybe we settle on a private helper in each one for now?
There was a problem hiding this comment.
nm, i went ahead an normalized them all. lots of deleted lines, so i think it was worth it
punktilious
reviewed
Oct 22, 2021
| @@ -257,7 +266,8 @@ public void testPrecisionWithExact() throws Exception { | |||
|
|
|||
| } | |||
|
|
|||
| @Test | |||
| // the new query builder cannot generate a where fragment that starts with AND | |||
There was a problem hiding this comment.
Just start the whereFragment with 1=1 before handing it to the behavior impl?
There was a problem hiding this comment.
yes, good idea. and i think i can encapsulate it in the runTest helper methods so that the individual test cases can look clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing the old xParmBehaviorUtil classes, I realized that we never updated their corresponding tests to the new builders. In the process of doing that, I discovered and fixed #2878 and #2879.
After this one, we still need to do some work if we want to remove the older-style jdbc cache implementations because they are still being used in places.