Issue 2843 - store both versioned and unversioned canonicals in ParametersMap #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParametersMap Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
prb112
reviewed
Nov 1, 2021
fhir-search/src/main/java/com/ibm/fhir/search/parameters/ParametersMap.java
Show resolved
Hide resolved
prb112
reviewed
Nov 1, 2021
fhir-search/src/main/java/com/ibm/fhir/search/parameters/ParametersMap.java
Show resolved
Hide resolved
prb112
reviewed
Nov 1, 2021
fhir-search/src/main/java/com/ibm/fhir/search/parameters/ParametersMap.java
Show resolved
Hide resolved
prb112
reviewed
Nov 1, 2021
Comment on lines
139
to
144
| @Deprecated | ||
| public Set<Entry<String, SearchParameter>> urlEntries() { | ||
| return Collections.unmodifiableSet(urlMap.entrySet()); | ||
| return Collections.unmodifiableSet(canonicalMap.entrySet().stream() | ||
| .filter(e -> !e.getKey().contains("|")) | ||
| .collect(Collectors.toSet())); | ||
| } |
There was a problem hiding this comment.
Maybe just remove these deprecated methods? No other team should be depending on this behavior. While observable, it shouldn't be a problem.
There was a problem hiding this comment.
i was trying to preserve backwards compatibility in the java where possible, but i'm ok removing them now if we don't want to wait
prb112
reviewed
Nov 1, 2021
fhir-search/src/test/java/com/ibm/fhir/search/parameters/ParametersSearchUtilTest.java
Show resolved
Hide resolved
prb112
reviewed
Nov 1, 2021
fhir-search/src/test/java/com/ibm/fhir/search/parameters/ParametersUtilTest.java
Outdated
Show resolved
Hide resolved
tbieste
reviewed
Nov 1, 2021
fhir-search/src/main/java/com/ibm/fhir/search/parameters/ParametersMap.java
Outdated
Show resolved
Hide resolved
This changeset introduces the fhir-ig-us-core as a test dependency for fhir-search. This was strictly out of convenience...the alternative would be to create a new test-only PackagedRegistryResourceProvider that provides multiple versions of the same search parameter(s). Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
force-pushed
the
issue-2843
branch
2 times, most recently
from
0983d7f
to
434ad4a
Compare
otherwise we run into the following error during validation if us-core is on the path: ``` SEVERE: validateResource(json/profiles/fhir-ig-us-core/Observation-some-day-smoker.json) unexpected failure: Input resource failed validation: generated-us-core-smokingstatus-5: Constraint violation: effective.where(is(dateTime)).exists() (Observation) ``` I also added back in the fhir-examples.version variable because I think our release automation still depends on this one (I had maybe accidentally removed it while removing the other variables for dependabot). Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
prb112
approved these changes
Nov 3, 2021
per review feedback Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added
the
breaking-change-java
per review feedback Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make this simpler, I also updated the way we apply the filter rules.
Note: this changeset introduces the fhir-ig-us-core as a test dependency for
fhir-search. This was strictly out of convenience...the alternative
would be to create a new test-only PackagedRegistryResourceProvider that
provides multiple versions of the same search parameter(s).