issue #3507 - treat "undelete" updates like create-on-update in changes #3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmsurpre
force-pushed
the
issue-3507
branch
4 times, most recently
from
c0d73e0 to
fee9e3a
Compare
Update db2 and postgresql add_any_resource.sql stored procs (and DerbyResourceDAO.storeResource) to write a 'C' instead of a 'U' for this case. This way, system and type-level history interactions can properly report the response status as a 201 instead of a 200. Note, however, that there are ongoing limitations for the accuracy of instance-level history entries as outlined at #3507 (comment) Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
force-pushed
the
issue-3507
branch
2 times, most recently
from
c8c3205 to
c7aa04d
Compare
punktilious
reviewed
Mar 30, 2022
fhir-persistence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/derby/DerbyResourceDAO.java
Show resolved
Hide resolved
punktilious
reviewed
Mar 30, 2022
fhir-server/src/main/java/com/ibm/fhir/server/util/FHIRRestHelper.java
Outdated
Show resolved
Hide resolved
punktilious
reviewed
Mar 30, 2022
...nce-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/postgres/PostgresResourceNoProcDAO.java
Show resolved
Hide resolved
punktilious
reviewed
Mar 30, 2022
...nce-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/postgres/PostgresResourceNoProcDAO.java
Outdated
Show resolved
Hide resolved
punktilious
reviewed
Mar 30, 2022
...nce-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/postgres/PostgresResourceNoProcDAO.java
Outdated
Show resolved
Hide resolved
per review feedback Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update db2 and postgresql add_any_resource.sql stored procs (and
DerbyResourceDAO.storeResource) to write a 'C' instead of a 'U' for this
case. This way, system and type-level history interactions can properly
report the response status as a 201 instead of a 200.
Update FHIRRestHelper.createHistoryBundle to handle this same case for
the instance-level history. Note, however, that there are ongoing
limitations for the accuracy of the instance-level history entries as
outlined at #3507 (comment)
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com