Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #3713 use distributed add_any_resource function for citus #3718

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

punktilious
Copy link
Collaborator

Signed-off-by: Robin Arnold robin.arnold@ibm.com

For Citus, we split the add_any_resource into two separate functions:

  1. add_logical_resource_ident - distributed by logical_id
  2. add_any_resource - distributed by logical_resource_id

The first function allocates the logical_resource_id used in the call to the second procedure. By using two separate distributed functions, we can lower latency on Citus, because each call gets routed to just one worker node (based on the value of the distribution parameter).

@lmsurpre lmsurpre self-requested a review June 20, 2022 19:35
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@punktilious punktilious merged commit 583903a into robin-citus-1 Jun 21, 2022
@punktilious punktilious deleted the robin-citus-2 branch June 21, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants