issue #3676 remove Db2 support #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
punktilious
commented
Jul 25, 2022
•
punktilious
commented
- removal of all things db2
- removal of the multitenant db schema flavor (which was only supported on db2)
- removal of the legacy approach to storing parameters (which was only used in db2)
- renamed CommonTokenValues classes (Cache and DAO) to CommonValues to reflect that they cover both token values and reference values now
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
…sistence API Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
lmsurpre
reviewed
Jul 25, 2022
|
|
||
| 1. Print the DDL and manually tweak it for your desired database; or | ||
| 2. Add configuration to control which IDatabaseAdapter and IDatabaseTranslator are used. | ||
|
|
||
| Note, the Db2 implementation uses stored procedures, the Postgres implementation uses Functions, and the Derby implementation is JDBC. | ||
| Note, the Postgres implementation uses Functions, and the Derby implementation is JDBC. |
There was a problem hiding this comment.
super minor
Suggested change
| Note, the Postgres implementation uses Functions, and the Derby implementation is JDBC. | |
| Note, the Postgres implementation uses Functions and the Derby implementation is JDBC. |
lmsurpre
reviewed
Jul 25, 2022
lmsurpre
reviewed
Jul 25, 2022
...stence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/citus/CitusResourceReferenceDAO.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jul 25, 2022
lmsurpre
reviewed
Jul 25, 2022
| @@ -82,21 +77,9 @@ public MigrateV0021AbstractTypeRemoval(IDatabaseAdapter adapter, String adminSch | |||
|
|
|||
| @Override | |||
| public void run(IDatabaseTranslator translator, Connection c) { | |||
There was a problem hiding this comment.
Not for this PR, but I wonder if our 5.0 is a chance to remove some of these historical migration objects.
Or, if not, maybe we deprecate them and remove in 6.0 (so we could support 4.x -> 5.x but we'd require 5.x to get to 6.x)
lmsurpre
reviewed
Jul 25, 2022
fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/patch/Main.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Jul 25, 2022
| // Pretend that our target is a DB2 database | ||
| Db2Adapter adapter = new Db2Adapter(tgt); | ||
| // Pretend that our target is a Derby database | ||
| DerbyAdapter adapter = new DerbyAdapter(tgt) { |
There was a problem hiding this comment.
in other cases we replaced with Postgres...any reason to target derby from this one?
There was a problem hiding this comment.
Yeah, because Postgres requires a whole bunch of doesXXExist methods to be overridden in the adapter which are currently private.
lmsurpre
reviewed
Jul 25, 2022
fhir-persistence-schema/src/test/java/com/ibm/fhir/schema/derby/OldFhirResourceTableGroup.java
Show resolved
Hide resolved
lmsurpre
reviewed
Jul 25, 2022
fhir-persistence-schema/src/test/java/com/ibm/fhir/schema/derby/OldFhirSchemaGenerator.java
Show resolved
Hide resolved
lmsurpre
approved these changes
Jul 25, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.