This repository has been archived by the owner on Oct 27, 2021. It is now read-only.
Implement NATS retries #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR created threads that start up the NATS subscribers. Once started, each NATS subscriber runs in its own thread and that is unaffected by this PR.
The threading on startup of the subscribers allows us to specify the number of retries and the wait time between retries, which makes it easier to start a set of LFH instances as a group and have them all connect to each other. With this configuration, if a subscriber is trying to connect to a LFH instance that is not up yet, it will keep retrying per the settings:
until the connection is made or there are no more retries.