Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support embed file upload #538

Merged
merged 3 commits into from
Sep 29, 2024
Merged

feat: support embed file upload #538

merged 3 commits into from
Sep 29, 2024

Conversation

LinuxSuRen
Copy link
Owner

We highly recommend you read the contributor's documentation before starting the review process especially since this is your first contribution to this project.

It was updated on 2024/5/27

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@LinuxSuRen LinuxSuRen added the enhancement New feature or request label Sep 29, 2024
Copy link

github-actions bot commented Sep 29, 2024

There are 1 test cases, failed count 0:

Name Average Max Min Count Error
9.931825ms 11.054383ms 9.355827ms 3 0

Reported by api-testing.

Copy link

sonarcloud bot commented Sep 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.12% (target: -1.00%) 63.64% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (344ed1b) 17366 7195 41.43%
Head commit (7c97658) 17791 (+425) 7393 (+198) 41.55% (+0.12%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#538) 11 7 63.64%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@LinuxSuRen LinuxSuRen merged commit 834a28f into master Sep 29, 2024
13 of 15 checks passed
@LinuxSuRen LinuxSuRen deleted the feat/fileupload branch September 29, 2024 07:34
@LinuxSuRen LinuxSuRen mentioned this pull request Sep 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant