Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inconsistencies when changing document directory #255

Closed
1 task done
solarkraft opened this issue Aug 17, 2022 · 6 comments
Closed
1 task done

[Bug]: Inconsistencies when changing document directory #255

solarkraft opened this issue Aug 17, 2022 · 6 comments
Assignees
Labels
bug Something isn't working confirmed
Milestone

Comments

@solarkraft
Copy link

solarkraft commented Aug 17, 2022

What happened?

When the document directory is changed, existing files aren't moved. This may be intentional (albeit arguably bad, since there's no other easy way to extract the files from the app's internal storage), however the old files are still shown in the quick open menu, but can't be accessed (a new blank file is shown).

Files can apparently also not be saved or created, neither can templates (see #254).

Folders can be created with the larger file menu, they also appear in the file system. When clicking "create" for a file in the "open" menu, simply nothing happens.

(Are the errors caught somewere?)

Version

1.4.2

Platform

Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@solarkraft solarkraft added the bug Something isn't working label Aug 17, 2022
@CodeDoctorDE CodeDoctorDE moved this to 📕 Todo in Butterfly Aug 17, 2022
@CodeDoctorDE CodeDoctorDE added this to the 1.4 milestone Aug 17, 2022
@CodeDoctorDE
Copy link
Member

Okay I found the issue. You can't use a directory outside of the documents folder. But I will add a notification that users will get a notification that this folder can't be used

@CodeDoctorDE
Copy link
Member

Okay,
Seems like flutter file picker doesn't support it currently: miguelpruivo/flutter_file_picker#721 (comment).
I disable this feature temporarily. The current files can be found in /Android/data/dev.linwood.butterfly

@solarkraft
Copy link
Author

Can confirm that saving files and templates work when in a sub-directory of /Documents.
A remaining bug is that the quick open menu still shows files that have been open from another location; actually opening them fails.

@CodeDoctorDE
Copy link
Member

I disabled it temporarily. I can't get the current document directory from android to test it. I need to test it more and reenable it after that again

@solarkraft
Copy link
Author

Templates and documents already in the folder also don't appear when changing to it, even after force stopping and deleting the cache.

@CodeDoctorDE
Copy link
Member

I fixed it now by disabling it on android. Maybe we should add an issue to reimplement it with a safer option. For now the syncing feature should help and the native file system(all files should be stored in /Android/data/dev.linwood.butterfly).
1.5 will implement a feature to export everything: #269

Repository owner moved this from 📕 Todo to ✅ Done in Butterfly Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
None yet
Development

No branches or pull requests

2 participants