Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mach is deprecated, update to mach2 #7

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

ameknite
Copy link
Contributor

Using cargo deny, I found that 'mach' is unmaintained. I suggest using 'mach2,' a fork that is maintained, instead of 'mach'. fitzgen/mach#63 (comment)

error[unmaintained]: mach is unmaintained
  ┌─ /slice_ring_buffer/Cargo.lock:2:12 │ mach 0.3.2 registry+https://github.com/rust-lang/crates.io-index
  │ ---------------------------------------------------------------- unmaintained advisory detected
  │
  = ID: RUSTSEC-2020-0168
  = Advisory: https://rustsec.org/advisories/RUSTSEC-2020-0168
  = Last release was almost 4 years ago.
    
    Maintainer(s) seem to be completely unreachable. 
    
    ## Possible Alternative(s)
    
    These may or may not be suitable alternatives and have not been vetted in any way;
    - [mach2](https://crates.io/crates/mach2) - direct fork
  = Announcement: https://github.com/fitzgen/mach/issues/63
  = Solution: No safe upgrade is available!
  = mach v0.3.2
    └── slice-ring-buffer v0.3.2

advisories FAILED, bans ok, licenses ok, sources ok
``` is unmaintained,

@ameknite
Copy link
Contributor Author

Also, pls publish a new version if this get merge

@LiquidityC
Copy link
Owner

Looks like the project has become slightly stale. I'll take a look at fixing up clippy and digging into what happened to the mips toolchain. Hopefully it's simple stuff.

@ameknite
Copy link
Contributor Author

@LiquidityC any updates?

@LiquidityC
Copy link
Owner

Yes. I'm sorry. Been swamped with work. I'll get to it ASAP.

@LiquidityC
Copy link
Owner

Those toolchains are "Tier 3" so I just dropped them to allow CI to pass. Pending my PR here #8

@LiquidityC
Copy link
Owner

You should be able to rebase now. Besides that there's a formatting warning in your CI run. Once those things are fixed we can merge.
The CI seems generally unstable. I myself don't have the time to dive into it at the moment so we'll just have to fiddle until it passes.

@ameknite
Copy link
Contributor Author

I rebase and fix the fmt, I hope now it can be merged

@LiquidityC LiquidityC merged commit e6c9949 into LiquidityC:master Nov 13, 2023
52 of 53 checks passed
github-merge-queue bot pushed a commit to bevyengine/bevy that referenced this pull request Nov 14, 2023
# Objective

Fix #9880

## Solution

- Add all-features flag 
- Allow "MPL-2.0" license for the
[Symphonia](https://github.com/pdeljanov/Symphonia) crates
- Update dependencies unmaintained or with vulnerabilities:
RustAudio/rodio#517 ,
LiquidityC/slice_ring_buffer#7
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
# Objective

Fix bevyengine#9880

## Solution

- Add all-features flag 
- Allow "MPL-2.0" license for the
[Symphonia](https://github.com/pdeljanov/Symphonia) crates
- Update dependencies unmaintained or with vulnerabilities:
RustAudio/rodio#517 ,
LiquidityC/slice_ring_buffer#7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants