Draft: Support for multiple BSLs/Clouds #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lirt
changed the title
Lirt
force-pushed
the
use-cloud-from-configuration
branch
from
82a80b7 to
cc12a6b
Compare
If we specify multiple clouds for example into clouds.yaml file, we need to have a way how to pick which cloud to use for specific backup. For this we can set cloud name into BackupStorageLocation or VolumeSnapshotLocation and plugin will pick which cloud to use for authentication and further operations. Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>
|
This PR is currently blocked by issue vmware-tanzu/velero#5582. Edit: The issue was in the code. I had to create new provider and client in every Init() request from Velero |
Lirt
force-pushed
the
use-cloud-from-configuration
branch
from
cc12a6b to
6e4d3b9
Compare
When using multiple backupstoragelocations velero switches between them executing various operations from plugin interface. In case we skip reauthentication velero can use old provider client and service client while in correct case it should authenticate again using another cloud ID Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>
Lirt
force-pushed
the
use-cloud-from-configuration
branch
from
15d649c to
0854b09
Compare
Lirt
changed the title
Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>
Lirt
force-pushed
the
use-cloud-from-configuration
branch
from
ebbf804 to
e3f6cfa
Compare
Signed-off-by: Ondrej Vasko <ondrej.vaskoo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we specify multiple clouds for example into clouds.yaml file, we need to have a way how to pick which cloud to use for specific backup. For this we can set cloud name into BackupStorageLocation or VolumeSnapshotLocation and plugin will pick which cloud to use for authentication and further operations.
Signed-off-by: Ondrej Vasko ondrej.vaskoo@gmail.com