Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper package name #77

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Set proper package name #77

merged 1 commit into from
Jun 27, 2023

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Jun 22, 2023

Resolves #74

@kayrus kayrus force-pushed the change-package-name branch from 7ed0bc5 to f4e374b Compare June 23, 2023 08:05
@kayrus
Copy link
Contributor Author

kayrus commented Jun 23, 2023

@Lirt ready for review

@kayrus kayrus force-pushed the change-package-name branch from f4e374b to b140244 Compare June 23, 2023 10:53
Lirt
Lirt approved these changes Jun 27, 2023
View reviewed changes
Copy link
Owner

@Lirt Lirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lirt
Copy link
Owner

Lirt commented Jun 27, 2023

Hi,
Is this MR OK to be merged as first? Probably followed by this small MR - https://github.com/Lirt/velero-plugin-for-openstack/pull/76/files?

@kayrus
Copy link
Contributor Author

kayrus commented Jun 27, 2023

The sequence doesn't really matter :)

@Lirt Lirt merged commit f2a1b8d into Lirt:master Jun 27, 2023
@kayrus kayrus deleted the change-package-name branch June 27, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lirt Lirt Lirt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Change go package name
2 participants
@kayrus @Lirt