Add support for share replicas AZ set #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayrus
force-pushed
the
manila-replicas
branch
3 times, most recently
from
1a0189a to
4768e23
Compare
kayrus
force-pushed
the
manila-replicas
branch
16 times, most recently
from
ef5567b to
667a76d
Compare
|
@Lirt rebased |
Lirt
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
The PR looks good, thank you again.
I will take some time to review the documentation and perform some manual testing. I plan to add cinder/manila integration tests, but I don't want to block this new release with it.
So if you're OK and finished all pending work, I will soon tag new release - 0.6.0 which will trigger build and push of a new docker image in CI.
|
would be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #80