Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Remove Dockerfile - Closes #88 #89

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Conversation

fchavant
Copy link
Contributor

@fchavant fchavant commented Jun 8, 2018

Remove images/ directory (Dockerfile), Jenkinsfile and update README.md now that LiskArchive/lisk-sdk#2056 has been merged.

@fchavant fchavant self-assigned this Jun 8, 2018
@fchavant fchavant force-pushed the 88-remove-dockerfile-keep-exmaples branch from 77ab774 to 19a799a Compare June 8, 2018 15:08
Copy link
Contributor

@diego-G diego-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea you had!

Copy link

@abelboldu abelboldu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing the Jenkinsfile? No CI for this repo?

@fchavant
Copy link
Contributor Author

@abelboldu the Jenkinsfile running docker build which we will do directly in the Docker Cloud now that the Dockerfile in in LiskHQ/lisk.

@fchavant fchavant merged commit b393693 into 2.1.0 Jun 12, 2018
@fchavant fchavant deleted the 88-remove-dockerfile-keep-exmaples branch June 12, 2018 07:43
fchavant added a commit that referenced this pull request Jun 28, 2018
Correct LISK_FORGING_DELEGATES_1 example value - Closes #89
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants