Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Connecting to unavailable custom node gives no 'Unable to connect to the node' #879

Closed
slaweet opened this issue Oct 17, 2017 · 1 comment
Closed

Connecting to unavailable custom node gives no 'Unable to connect to the node' #879

slaweet opened this issue Oct 17, 2017 · 1 comment
Labels
bug *easy

Comments

@slaweet
Copy link
Contributor

slaweet commented Oct 17, 2017

Expected behaviour

Connecting to an unavailable custom node should give 'Unable to connect to the node' error toast.

Actual behaviour

Connecting to unavailable custom node no longer gives the 'Unable to connect to the node' error toast.

Steps to reproduce

Try to log in to Custom Node that doesn't exist, e.g. http://localhost:4218
@slaweet slaweet changed the title Connecting to unavailable custom node no'Unable to connect to the node' Connecting to unavailable custom node gives no 'Unable to connect to the node' Oct 17, 2017
@slaweet
Copy link
Contributor Author

slaweet commented Oct 17, 2017

It's related to
https://github.com/LiskHQ/lisk-nano/blob/5b5fa1f39c8a1bbd9d09bd8c1bf0e3c49ea589c2/src/actions/peers.js#L41-L44
Because now it's the first request we do.

@ginacontrino ginacontrino self-assigned this Oct 17, 2017
@ginacontrino ginacontrino mentioned this issue Oct 17, 2017
Merged
ginacontrino pushed a commit that referenced this issue Oct 18, 2017
Merge pull request #880 from LiskHQ/879-custom-node-error-toast
83c07ad 
Add missing error toast for unavailable custom node - Closes #879
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug *easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slaweet @ginacontrino