Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Add error messages for autocomplete - Closes #823 #836

Merged
merged 5 commits into from
Oct 6, 2017

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Oct 5, 2017

What's the Problem?
We make an unnecessary request every 10 second just to check if the client is online or not.
#823

What did you do?

  • added an extra check and added error message
  • added one translation

How can I test this?

  • go to "Vote"
  • check for both "Add vote to" and "Remove vote from" that :
    • the search is still working (showing results)
    • when you search for something that doesn't exist, the autocomplete should be blank and the
      error message "No matches" appears

It should look like this:
screen shot 2017-10-05 at 11 46 14

Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @ginacontrino

@ginacontrino ginacontrino merged commit eaaba4d into development Oct 6, 2017
@ginacontrino ginacontrino deleted the 823-delegate-autocomplete branch October 6, 2017 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants