Skip to content
This repository has been archived by the owner on Jan 14, 2022. It is now read-only.

Update startup script to use network option #102

Closed
nazarhussain opened this issue Jun 25, 2018 · 5 comments
Closed

Update startup script to use network option #102

nazarhussain opened this issue Jun 25, 2018 · 5 comments

Comments

@nazarhussain
Copy link
Contributor

nazarhussain commented Jun 25, 2018

With the issue LiskArchive/lisk-sdk#398 when PR LiskArchive/lisk-sdk#2149 will be ready. We have to update all startup scripts and configuration to follow network command line option to start the node for specific network.

https://github.com/LiskHQ/lisk-scripts/blob/21f2e4af14f0ab9f00eec3a90f8c44d864dd373b/packaged/etc/pm2-lisk.json#L14

https://github.com/LiskHQ/lisk-scripts/blob/21f2e4af14f0ab9f00eec3a90f8c44d864dd373b/packaged/etc/pm2-snapshot.json#L15

So above code will be come.

"args": "-c config.json -n devnet",

Available networks that can be configured are devnet, betanet, testnet and mainnet.

@fchavant
Copy link
Contributor

fchavant commented Jul 17, 2018

Is this something lisk-build should be doing maybe?
lisk-build pulls files lisk-scripts and puts them into place and gets called with a -n switch so it'd be trivial to modify etc/pm2-*.json there (LiskArchive/lisk-build#292)

@nazarhussain
Copy link
Contributor Author

@fchavant May be lisk-build just use env variable LISK_NETWORK and don't touch these files. Its up to you and @Nazgolze how to implement int.

@fchavant
Copy link
Contributor

My point is this is something that should be done in lisk-build and there is an issue over there. This issue here in lisk-scripts could be closed IMO.

@nazarhussain
Copy link
Contributor Author

Yes please discuss with @Nazgolze and refer the issue in lisk-build and close this issue.

@Nazgolze
Copy link
Contributor

Closing in favor of doing this in lisk-build

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants