🌱 Add block asset validation

- Expose registered module ids from state machine
- Check the size of data of an asset not exceeding the limit
- Check a module asset is not duplicated
- Check a module assets are sorted by id and are registered in state machine

elements/lisk-chain/src/block.ts

@@ -15,6 +15,7 @@
 import { codec } from '@liskhq/lisk-codec';
 import { BlockAssets } from './block_assets';
 import { BlockHeader } from './block_header';
+import { MAX_ASSET_DATA_SIZE_BYTES } from './constants';
 import { blockSchema } from './schema';
 import { Transaction } from './transaction';
 
@@ -76,5 +77,26 @@ export class Block {
 		for (const tx of this.payload) {
 			tx.validate();
 		}
+
+		const assets = this.assets.getAllAssets();
+		let last = assets[0];
+		let i = 0;
+		for (const asset of assets) {
+			// Data size of each module should not be greater than max asset data size
+			if (asset.data.byteLength > MAX_ASSET_DATA_SIZE_BYTES) {
+				throw new Error(
+					`Module with ID ${asset.moduleID} has data size more than ${MAX_ASSET_DATA_SIZE_BYTES} bytes.`,
+				);
+			}
+			if (last.moduleID > asset.moduleID) {
+				throw new Error('Assets are not sorted in the increasing values of moduleID.');
+			}
+			// Check for duplicates
+			if (i > 0 && asset.moduleID === last.moduleID) {
+				throw new Error(`Module with ID ${assets[i].moduleID} has duplicate entries.`);
+			}
+			i += 1;
+			last = asset;
+		}
 	}
 }

elements/lisk-chain/src/block_assets.ts

@@ -46,6 +46,10 @@ export class BlockAssets {
 		return this._assets.find(a => a.moduleID === moduleID)?.data;
 	}
 
+	public getAllAssets(): BlockAsset[] {
+		return [...this._assets];
+	}
+
 	public setAsset(moduleID: number, value: Buffer): void {
 		const asset = this.getAsset(moduleID);
 		if (asset) {

elements/lisk-chain/src/constants.ts

@@ -28,3 +28,6 @@ export const GENESIS_BLOCK_TRANSACTION_ROOT = EMPTY_HASH;
 
 export const TAG_BLOCK_HEADER = createMessageTag('BH');
 export const TAG_TRANSACTION = createMessageTag('TX');
+
+// TODO: Actual size TBD
+export const MAX_ASSET_DATA_SIZE_BYTES = 64;

framework/src/node/consensus/consensus.ts

@@ -484,8 +484,17 @@ export class Consensus {
 
 		// verify Block signature
 		await this._verifyBlockSignature(apiContext, block);
+
 		// Verify validatorsHash
 		await this._verifyValidatorsHash(apiContext, block);
+
+		// Validate a block
+		block.validate();
+		for (const asset of block.assets.getAllAssets()) {
+			if (!this._stateMachine.getAllModuleIDs().includes(asset.moduleID)) {
+				throw new Error(`Module with ID: ${asset.moduleID} is not registered.`);
+			}
+		}
 	}
 
 	private async _verifyTimestamp(apiContext: APIContext, block: Block): Promise<void> {

framework/src/node/state_machine/state_machine.ts

@@ -51,15 +51,24 @@ export interface StateMachineModule {
 export class StateMachine {
 	private readonly _modules: StateMachineModule[] = [];
 	private readonly _systemModules: StateMachineModule[] = [];
+	private readonly _moduleIDs: number[] = [];
 
 	public registerModule(mod: StateMachineModule): void {
 		this._validateExistingModuleID(mod.id);
 		this._modules.push(mod);
+		this._moduleIDs.push(mod.id);
+		this._moduleIDs.sort((a, b) => a - b);
 	}
 
 	public registerSystemModule(mod: StateMachineModule): void {
 		this._validateExistingModuleID(mod.id);
 		this._systemModules.push(mod);
+		this._moduleIDs.push(mod.id);
+		this._moduleIDs.sort((a, b) => a - b);
+	}
+
+	public getAllModuleIDs() {
+		return this._moduleIDs;
 	}
 
 	public async executeGenesisBlock(ctx: GenesisBlockContext): Promise<void> {