Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Inconsistent response for /transactions endpoint #1884

Closed
lsilvs opened this issue Apr 16, 2018 · 2 comments
Closed

Inconsistent response for /transactions endpoint #1884

lsilvs opened this issue Apr 16, 2018 · 2 comments

Comments

@lsilvs
Copy link
Contributor

lsilvs commented Apr 16, 2018

Expected behavior

Given I make the following calls:

/transactions?blockId=:blockId&sort=timestamp:desc&offset=0&limit=51 and
/transactions?blockId=:blockId&sort=timestamp:desc&offset=50&limit=51

I expect the last item returned by the first call to be the same as the first item returned by the second call.

Actual behavior

It is not.

Steps to reproduce

Using the following test database:

Compare the first call with the second call

Which version(s) does this affect? (Environment, OS, etc...)

v1.0.0-beta.5

@diego-G
Copy link

diego-G commented Apr 26, 2018

Your calls are getting transactions with timestamp 0. What we need is a second default sort parameter as a tiebreaker.

@diego-G diego-G self-assigned this Apr 26, 2018
@diego-G diego-G added this to the Version 1.0.0-beta.8 milestone Apr 26, 2018
@diego-G diego-G assigned Tschakki and unassigned diego-G Apr 26, 2018
@lsilvs
Copy link
Contributor Author

lsilvs commented Apr 26, 2018

Maybe it's a good idea to introduce this second default sort for all endpoints that have sorting option.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants