This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Make transactions endpoint pagination consistent - Closes #1884 #1969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
In case the first sorting param for transaction is not precise enough, pagination of the transactions endpoint was not consistent.
How did I fix it?
Added a second sorting param, which determines the order in that the transactions get returned, if the first sorting param is not precise enough.
How to test it?
the last entry of this call:
http://localhost:4000/api/transactions?blockId=6524861224470851795&sort=timestamp:desc&offset=0&limit=51
and the first entry of this call:
http://localhost:4000/api/transactions?blockId=6524861224470851795&sort=timestamp:desc&offset=50&limit=51
should be always identical.
Review checklist