Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Make transactions endpoint pagination consistent - Closes #1884 #1969

Closed
wants to merge 2 commits into from

Conversation

Tschakki
Copy link
Contributor

@Tschakki Tschakki commented Apr 30, 2018

What was the problem?

In case the first sorting param for transaction is not precise enough, pagination of the transactions endpoint was not consistent.

How did I fix it?

Added a second sorting param, which determines the order in that the transactions get returned, if the first sorting param is not precise enough.

How to test it?

the last entry of this call:
http://localhost:4000/api/transactions?blockId=6524861224470851795&sort=timestamp:desc&offset=0&limit=51
and the first entry of this call:
http://localhost:4000/api/transactions?blockId=6524861224470851795&sort=timestamp:desc&offset=50&limit=51
should be always identical.

Review checklist

@Tschakki Tschakki changed the base branch from development to 1.0.0 April 30, 2018 14:02
@Tschakki Tschakki force-pushed the 1884-make_tx_endpoint_pagination_consistent branch from c575126 to c60ac13 Compare April 30, 2018 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants