Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Networks lose stability when broadcasting transactions #339

Closed
ghost opened this issue Dec 6, 2016 · 10 comments
Closed

Networks lose stability when broadcasting transactions #339

ghost opened this issue Dec 6, 2016 · 10 comments

Comments

@ghost
Copy link

ghost commented Dec 6, 2016

I've noticed that shortly after my delegate sharing pool made withdraws, around ~100. Network lost stability, and it took few minutes for most of nodes to get back in sync.
screen shot 2016-12-06 at 20 20 15

Note: 3 last fields in table are incorrect temporary

@ghost
Copy link
Author

ghost commented Dec 6, 2016

It seems some nodes stucked on other heights and forked.

@Isabello
Copy link
Contributor

Isabello commented Dec 6, 2016 via email

@ghost
Copy link
Author

ghost commented Dec 6, 2016

I've not checked logs yet, but none of my nodes forked, there are few people on #mainnet, lisk.chat which experienced fork.

@Isabello
Copy link
Contributor

Isabello commented Dec 6, 2016 via email

@ghost
Copy link
Author

ghost commented Dec 6, 2016

I think most problem is that network lost stability when ~100 transactions was made at one time. No need to debug it more, just need to analyse code responsible for that further and improve. Since forks occurred after stability has been lost. Forks should be avoided not only fixed temporary by recovering mechanism but i can agree that recovering mechanism is necessary as much. I've reported what i've noticed, hope it's helpful. For me it would be.

@Isabello
Copy link
Contributor

Isabello commented Dec 6, 2016

The network is accepting fork forged blocks is most likely the root cause of nodes falling behind and staying behind, not transaction processing and broadcast. This has been proven time and again that accepting incorrect blocks the main issue we are having when it comes to nodes falling behind.

@ghost
Copy link
Author

ghost commented Dec 7, 2016

Adding video from today test
https://youtu.be/gtdVNEb3ccQ

It clearly shows that propagation time increase badly when transactions are submitted, also some nodes get out of sync after that and needs some time to recover. it appears that network can be possibly killed for less than 10k LSK, 5$ VPS, and some effort.

I wouldn't call Mainchain Stabilisation Milestone Finished

@karmacoma
Copy link
Contributor

@karek314 Comparatively speaking to previous releases the network is more stable. We have staged multiple tests on a network similar in size and had no problems with 1000s of transactions. I'm not sure what your intentions are by posting such a video, but from my point of view they are bad.

Anyway, we will review the current situation and if there is a problem, we will resolve it.

@ghost
Copy link
Author

ghost commented Dec 7, 2016

I can agree that is more stable, actually much more stable, but not stable enough yet - i wouldn't call it stable main chain. Video clearly shows propagation time issues. Why bad intentions ? This is not some unknown exploit, this is actually the simplest attack, currently incentive to attack Lisk network is very very small, there is no margin trading, lisk have nowhere to drop. It would be very hard to benefit from that.

@MaciejBaj
Copy link
Contributor

Not occurring in 1.0.0 version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants