Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Create function to write keys #5228

Closed
pablitovicente opened this issue Apr 29, 2020 · 0 comments · Fixed by #5322
Closed

Create function to write keys #5228

pablitovicente opened this issue Apr 29, 2020 · 0 comments · Fixed by #5322
Assignees
@shuse2
Labels
elements/codec
Milestone
Sprint 20

Comments

@pablitovicente
Copy link
Contributor

pablitovicente commented Apr 29, 2020 •
edited by karmacoma
Loading

Description

Create generateKey(fieldNumber, wireType ) => varint

Motivation

Messages are encoded as key-value pairs therefore we need a function to generate keys based on the LIP.

Acceptance Criteria

  • generateKey() returns valid varint representation of keys as per the LIP
  • Add unit tests for generateKey

Additional Information

Related issues: #5200
@ManuGowda ManuGowda mentioned this issue Apr 30, 2020
Closed
@ManuGowda ManuGowda changed the title Create writer for keys Create function to write keys May 6, 2020
@sridharmeganathan sridharmeganathan added this to the Sprint 19 milestone May 10, 2020
@pablitovicente pablitovicente mentioned this issue May 13, 2020
Merged
@shuse2 shuse2 assigned shuse2 and unassigned pablitovicente May 22, 2020
shuse2 added a commit that referenced this issue May 25, 2020
@shuse2
Merge pull request #5322 from LiskHQ/5217-create_function_to_traverse…
58705ef 
…_the_object_for_encoding

Create function to traverse the object for encoding - Closes #5217 & #5228 & #5235
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
elements/codec
Projects
None yet
Milestone
Sprint 20
3 participants
@pablitovicente @shuse2 @sridharmeganathan