Refactor code and improve unit/integration tests

[sridharmeganathan]

Motivation

With the implementation of Network Longevity roadmap objectives we found certain parts of code could be refactored and add missing unit/integration tests for better code coverage.

Tasks

• Update P2P examples Update P2P examples #5511
• Add validator, utils, codec and tree to lisk-client package Add validator, utils, codec and tree to lisk-client package and db, utils, p2p from SDK and elements #5565

Sprint 21

• Add tests for application actions and events Add tests for application actions and events #4894
• Update transactions to be first order function Update transactions to be first order function #5088
• Remove crypti copyright from readme for new packages Remove crypti copyright from readme for new packages #5325
• Update event name to be consistent across SDK Update event name to be consistent across SDK #5389
• Update all config and logs to use Base64 instead of hex Update all config and logs to use Base64 instead of hex #5390
• Add validation keyword for data type Add validation keyword for data type #5394
• Update lisk-codec interface type Update lisk-codec interface type #5395
• Make all lisk-cryptography functions to consistently use Buffer for keys Make all lisk-cryptography functions to consistently use Buffer for keys #5403

Sprint 22

• Add JSON decode and encode for the lisk-codec Add JSON decode and encode for the lisk-codec #5354
• Update the regex for application version to be flexible and just follow semantic versioning Update the regex for application version to be flexible and just follow semantic versioning #5416
• Update all regexpr to be valid and match valid data Update all regexpr to be valid and match valid data #5418
• Improved and more readable validation error format from Lisk SDK Improved and more readable validation error format from Lisk SDK #5432
• Redefine exposed actions from the framework Redefine exposed actions from the framework #5440
• Remove public key from account state and all the usage of public key Remove public key from account state and all the usage of public key #5471
• Update eslint version Update eslint version #5476
• Remove modules/http_api and enable eslint rules on framework Remove modules/http_api and enable eslint rules on framework #5477
• Peer should not be banned by getTransactions endpoint Peer should not be banned by getTransactions endpoint #5484
• Synchronization should end successfully Synchronization should end successfully #5486
• Consolidate devnet config and place it in lisk-sdk root folder Consolidate devnet config and place it in lisk-sdk root folder #5488
• Node should restart without error Node should restart without error #5490
• Add index file to application and controller Add index file to application and controller #5494
• Update SDK exported libraries Update SDK exported libraries #5501

Sprint 23

• Redefine P2P communication and message formats after using Lisk-codec Redefine P2P communication and message formats after using lisk-codec #5419
• Rename protocolVersion to networkVersion Rename protocolVersion to networkVersion #5472
• Apply format (prettier) for all the files Apply format (prettier) for all the files #5478
• Remove diff stored on finality and not store when equal Remove diff stored on finality and not store when equal #5505
• While syncing it fails to process block because of maxHeightPrevoted While syncing it fails to process block because of maxHeightPrevoted #5506
• Fail to reload temp blocks because of maxPrevoteHeight Fail to reload temp blocks because of maxPrevoteHeight #5507
• Restarting the synchronization should successfully restart the synchronization Restarting the synchronization should successfully restart the synchronization #5508
• Remove all references of public actions feature from controller Remove all references of public actions feature from controller #5509
• Update child process IPC communication integration test Update child process IPC communication integration test #5512
• Update genesis block and config reading to use fromJSON function Update genesis block and config reading to use fromJSON function #5513
• Add temporal complete diff save Add temporal complete diff save #5522
• Rename wsPort -> port in framework for websocket port Rename wsPort -> port in framework for websocket port #5527
• Update application state to have only fields that are required in framework Update application state to have only fields that are required in framework #5528
• Fast chain switching fails on the common block Fast chain switching fails on the common block #5531
• lastBlockId should be type bytes lastBlockId should be type bytes #5544
• External types d.ts is not published to the repo External types d.ts is not published to the repo #5551
• Fix unlock transaction validate asset error path Fix unlock transaction validate asset error path #5557
• Remove lodash from framework Remove lodash from framework #5563

Sprint 24

• Add Stop function in job queue Add Stop function in job queue #5567
• Update transaction create, sign, signature functions Update transaction create, sign, signature functions #5571
• HTTP Plugin error handling incorrect for POST /api/transactions HTTP Plugin error handling incorrect for POST /api/transactions #5594
• Missing events for module unloading lifecycle as specified in LIP Missing events for module unloading lifecycle as specified in LIP #3632
• unload() not being called in plugins when running plugins as child process unload() not being called in plugins when running plugins as child process #5562
• /api/blocks?height=10 should return data as an array /api/blocks?height=10 should return data as an array #5564
• Higher nonce transactions are rejected by pool Higher nonce transactions are rejected by pool  #5529