Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Rename protocolVersion to networkVersion #5472

Closed
shuse2 opened this issue Jun 26, 2020 · 0 comments
Closed

Rename protocolVersion to networkVersion #5472

shuse2 opened this issue Jun 26, 2020 · 0 comments
Assignees
@ishantiw
Labels
elements/P2P unplanned
Milestone
Sprint 23

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Jun 26, 2020

Description

Update all the usages of protocolVersion to networkVersion. Main places are

Motivation

protocolVersion refers to the protocol, but it was used for network compatibility.
Therefore, we want to change the name to networkVersion

Acceptance Criteria

There should not be any protocolVersion mentioned in the SDK
@shuse2 shuse2 changed the title Update protocolVersion to networkVersion Rename protocolVersion to networkVersion Jun 26, 2020
@shuse2 shuse2 added this to the Sprint 22 milestone Jun 29, 2020
@ishantiw ishantiw mentioned this issue Jul 3, 2020
Merged
@sridharmeganathan sridharmeganathan mentioned this issue Jul 4, 2020
Closed
@sridharmeganathan sridharmeganathan modified the milestones: Sprint 22, Sprint 23 Jul 6, 2020
shuse2 added a commit that referenced this issue Jul 8, 2020
@shuse2
Merge pull request #5514 from LiskHQ/5419_redefine_p2p_communication
0c2209c 
Redefine p2p communication and update nodeInfo - Closes #5419 & #5472
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ishantiw ishantiw

Labels
elements/P2P unplanned
Projects
None yet
Milestone
Sprint 23
Development

No branches or pull requests
3 participants
@shuse2 @ishantiw @sridharmeganathan