Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix the lisk-client build process to exclude BLS functions and sodium-native build from export #6473

Closed
nazarhussain opened this issue Jun 7, 2021 · 0 comments

Comments

@nazarhussain
Copy link
Contributor

Description

Currently we are exporting everything lisk-cryptography from the lisk-client package. We have to fix this export to exclude BLS related functions and sodium-native dependency.

https://github.com/LiskHQ/lisk-sdk/blob/4dcd06ddca5248e736adb6ef88dca74c25fd05c9/elements/lisk-client/src/index.ts#L18

Motivation

The Lisk-Client package is intended to use in the browser and BLS and sodium native should never be used from browser. So we have to exclude the export in the lisk-client package.

Acceptance Criteria

  • BLS related functions signBLS, verifyBLS, createAggSig, verifyAggSig and others defined in this section should be excluded.
  • BLST dependency should not be injected in the lisk-client package.
  • Sodium-Native dependency should not be injected in the lisk-client package
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants