Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Additional cases for unit tests of validators module methods #7851

Closed
Tracked by #7208
Incede opened this issue Dec 1, 2022 · 0 comments · Fixed by #7910
Closed
Tracked by #7208

Additional cases for unit tests of validators module methods #7851

Incede opened this issue Dec 1, 2022 · 0 comments · Fixed by #7910
Labels
framework type: bug type: test
Milestone
Sprint 86

Comments

@Incede
Copy link
Contributor

Incede commented Dec 1, 2022

registerValidatorKeys

  • validatorAddress length is less than 20 bytes
  • validatorAddress length is greater than 20 bytes
  • generatorKey length is less than 32 bytes
  • generatorKey length is greater than 32 bytes
  • blsKey length is less than 48 bytes
  • blsKey length is greater than 48 bytes

registerValidatorWithoutBLSKey

  • validatorAddress length is less than 20 bytes
  • validatorAddress length is greater than 20 bytes
  • generatorKey length is less than 32 bytes
  • generatorKey length is greater than 32 bytes

setValidatorBLSKey

  • validatorAddress length is less than 20 bytes
  • validatorAddress length is greater than 20 bytes
  • blsKey length is less than 48 bytes
  • blsKey length is greater than 48 bytes

setValidatorGeneratorKey

  • validatorAddress length is less than 20 bytes
  • validatorAddress length is greater than 20 bytes
  • generatorKey length is less than 32 bytes
  • generatorKey length is greater than 32 bytes

getAddressFromBLSKey

  • blsKey length is less than 48 bytes
  • blsKey length is greater than 48 bytes
@Incede Incede mentioned this issue Dec 1, 2022
Closed
@Madhulearn Madhulearn added this to the Sprint 85 milestone Dec 19, 2022
@Incede Incede mentioned this issue Dec 19, 2022
Merged
shuse2 pushed a commit that referenced this issue Jan 2, 2023
@Incede
Additional cases for unit tests of validators module methods (#7910)
721fb00 
### What was the problem?

This PR resolves #7851 

### How was it solved?

Update tests as specified

### How was it tested?

Unit tests updated
@Madhulearn Madhulearn modified the milestones: Sprint 85, Sprint 86 Jan 3, 2023
@shuse2 shuse2 moved this from Backlog to Done in Lisk SDK Version 6.0.0 Jan 6, 2023
@shuse2 shuse2 mentioned this issue Jan 27, 2023
Closed
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
framework type: bug type: test
Projects
None yet
Milestone
Sprint 86
Development

Successfully merging a pull request may close this issue.

Additional cases for unit tests of validators module methods LiskArchive/lisk-sdk
2 participants
@Incede @Madhulearn