Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove transaction applyUnconfirmed and undoUnconfirmed from related modules #991

Closed
27 tasks done
Isabello opened this issue Nov 16, 2017 · 0 comments
Closed
27 tasks done

Remove transaction applyUnconfirmed and undoUnconfirmed from related modules #991

Isabello opened this issue Nov 16, 2017 · 0 comments
Assignees
@LucasIsasmendi
Labels
type: refactoring

Comments

@Isabello
Copy link
Contributor

Isabello commented Nov 16, 2017 •
edited by karmacoma
Loading

Parent: #972

Remove the following functions Transaction process/verify within the called modules.

applyUnconfirmed Remove functions from modules

  • TRANSACTION
    BLOCKS
  • TRANSFER
  • SECOND_SIGNATURE
  • DELEGATE REGISTRATION
  • DELEGATE VOTE
  • MULTISIGNATURE REGISTRATION
  • DAPP REGISTRATION
  • IN TRANSFER
  • OUT TRANSFER

undoUnconfirmed Remove functions from modules

  • TRANSACTION
    BLOCKS
  • TRANSFER
  • SECOND_SIGNATURE
  • DELEGATE REGISTRATION
  • DELEGATE VOTE
  • MULTISIGNATURE REGISTRATION
  • DAPP REGISTRATION
  • IN TRANSFER
  • OUT TRANSFER

tests Remove related tests from modules

  • TRANSACTION
  • TRANSFER
  • SECOND_SIGNATURE
  • DELEGATE REGISTRATION
  • DELEGATE VOTE
  • MULTISIGNATURE REGISTRATION
  • DAPP REGISTRATION
  • IN TRANSFER
  • OUT TRANSFER
@Isabello Isabello self-assigned this Nov 16, 2017
@karmacoma karmacoma mentioned this issue Nov 16, 2017
Closed
@Isabello Isabello changed the title Remove transaction applyUnconfirmed/undoUnconfirmed from related modules Remove transaction applyUnconfirmed and undoUnconfirmed from related modules Nov 16, 2017
@LucasIsasmendi LucasIsasmendi mentioned this issue Dec 12, 2017
Merged
@LucasIsasmendi LucasIsasmendi self-assigned this Dec 12, 2017
karmacoma added a commit that referenced this issue Dec 12, 2017
@karmacoma
Merge pull request #1132 from LiskHQ/991-remove-unconfirmed
393b482 
Remove transaction applyUnconfirmed and undoUnconfirmed from related modules - Closes #991
shuse2 added a commit that referenced this issue Apr 15, 2019
@shuse2
Merge pull request #991 from LiskHQ/979-use_discover_peers_func_in_p2p
4a578cb 
Use discover peers function in p2p - Closes#979
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LucasIsasmendi LucasIsasmendi

Labels
type: refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karmacoma @LucasIsasmendi @Isabello