Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Remove unused libraries json-schema, validator & validator.js - Closes #1957 #1959

Merged
merged 1 commit into from
May 2, 2018

Conversation

diego-G
Copy link

@diego-G diego-G commented Apr 27, 2018

Review checklist

@@ -64,7 +64,6 @@
"istanbul-middleware": "=0.2.2",
"js-yaml": "=3.10.0",
"json-refs": "=3.0.3",
"json-schema": "=0.2.3",
Copy link
Contributor

@nazarhussain nazarhussain Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diego-G I am not sure, if that really is a unused library Because I am sure z-schema can't work without json-schema. Need to investigate it in detail.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If z-schema cannot work without json-schema probably they install json-schema as a dependency.... ??

@diego-G diego-G changed the title Remove unused librarires json-schema, validator & validator.js - Close #1957 Remove unused libraries json-schema, validator & validator.js - Close #1957 Apr 27, 2018
@diego-G diego-G force-pushed the 1957-remove_unused_validator_libraries branch from 5c5b639 to 56ea1ba Compare April 27, 2018 16:04
@MaciejBaj MaciejBaj changed the title Remove unused libraries json-schema, validator & validator.js - Close #1957 Remove unused libraries json-schema, validator & validator.js - Closes #1957 May 2, 2018
@MaciejBaj MaciejBaj merged commit c6901f6 into 1.0.0-beta.8 May 2, 2018
@MaciejBaj MaciejBaj deleted the 1957-remove_unused_validator_libraries branch May 2, 2018 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants