This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Cleanup tests to use "devnet" configuration files to run all tests - Closes #2156 #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
force-pushed
the
2156-cleanup-test-suit
branch
from
bae0e80 to
ff5ea0f
Compare
nazarhussain
force-pushed
the
2156-cleanup-test-suit
branch
from
ff5ea0f to
d7c255d
Compare
4miners
suggested changes
Jul 3, 2018
| @@ -369,7 +368,7 @@ describe('system test (blocks) - chain/applyBlock', () => { | |||
| payloadHash: | |||
| 'be0df321b1653c203226add63ac0d13b3411c2f4caf0a213566cbd39edb7ce3b', | |||
| payloadLength: 494, | |||
| previousBlock: genesisBlock.id, | |||
| previousBlock: __testContext.config.genesisBlock, | |||
There was a problem hiding this comment.
Why not __testContext.config.genesisBlock.id?
test/integration/setup/network.js
Outdated
| @@ -22,7 +22,7 @@ var utils = require('../utils'); | |||
|
|
|||
| module.exports = { | |||
| waitForAllNodesToBeReady(configurations, cb) { | |||
| const retries = 20; | |||
| const retries = 40; | |||
There was a problem hiding this comment.
Why we need to increase that?
There was a problem hiding this comment.
This was messed up from me. I staged some changes, but whole file was committed.
nazarhussain
force-pushed
the
2156-cleanup-test-suit
branch
from
594de90 to
b3f8473
Compare
4miners
approved these changes
Jul 3, 2018
|
Great work @nazarhussain 👍 |
MaciejBaj
approved these changes
Jul 3, 2018
diego-G
added a commit
that referenced
this pull request
Jul 4, 2018
diego-G
added a commit
that referenced
this pull request
Jul 5, 2018
diego-G
added a commit
that referenced
this pull request
Jul 5, 2018
diego-G
added a commit
that referenced
this pull request
Jul 6, 2018
This was referenced Sep 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
There were redundant configuration file, to be only used in running the tests.
How did I fix it?
Removed the redundant file and used the devnet configuration files.
How to test it?
Run all tests.
Review checklist