This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

BigNumber in round calculations - Closes #447 #450

Merged

karmacoma merged 8 commits into LiskArchive:development from MaciejBaj:447-round-bignum

Mar 2, 2017

Contributor

MaciejBaj commented Feb 27, 2017 •

edited by karmacoma

Loading

Update library BigNumber from 1.3 to 4.0 version. Main changes:

Support for NaN and Infinity
Always create BigNumber values with new keyword

Change the way of how bignum.js is used- install bignumber.js as npm dependency and extend it in the separate file.

Closes #447

MaciejBaj added 2 commits

February 27, 2017 08:37


          provide tests for checking rounds precision issues

92b2807


          use bignum for round calculations, update bignumber.js version

b453586

karmacoma added the type: bug label

karmacoma self-assigned this

coveralls commented Feb 27, 2017 •

edited

Loading

Coverage increased (+3.6%) to 68.464% when pulling b453586 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

karmacoma changed the title ~~BigNumber in round calculations~~ BigNumber in round calculations - Closes #447

Oliver Beddows added 3 commits

February 28, 2017 15:01


          Reviewing code

24e3c9b


          Removing jshint overrides

ad24a2f


          Tidying comments

7215f99

coveralls commented Feb 28, 2017 •

edited

Loading

Coverage increased (+3.7%) to 68.581% when pulling 7215f99 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

Oliver Beddows added 2 commits

February 28, 2017 16:01


          Reviewing example descriptions


          Reviewing example descriptions

9efd775

coveralls commented Feb 28, 2017 •

edited

Loading

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

9 similar comments

coveralls commented Feb 28, 2017

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017

Coverage decreased (-5.7%) to 59.21% when pulling 4720061 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Feb 28, 2017 •

edited

Loading

Coverage increased (+2.6%) to 67.502% when pulling 9efd775 on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.


          Refactoring tests

e84c59c

- Reviewing example descriptions.
- Testing examples against valid scope.

coveralls commented Mar 2, 2017 •

edited

Loading

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

5 similar comments

coveralls commented Mar 2, 2017

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Mar 2, 2017

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Mar 2, 2017

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Mar 2, 2017

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Mar 2, 2017

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Mar 2, 2017

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

1 similar comment

coveralls commented Mar 2, 2017

Coverage decreased (-5.2%) to 59.706% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

coveralls commented Mar 2, 2017 •

edited

Loading

Coverage decreased (-4.8%) to 60.07% when pulling e84c59c on MaciejBaj:447-round-bignum into dd51e5a on LiskHQ:development.

karmacoma approved these changes

View reviewed changes

karmacoma merged commit 498dac2 into LiskArchive:development

karmacoma deleted the 447-round-bignum branch

March 2, 2017 17:04

karmacoma added ready and removed type: bug chore type: docs type: improvement type: test labels

snyk-bot mentioned this pull request

[Snyk] Fix for 1 vulnerabilities Matthelonianxl/lisk#29

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet