Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add lisk-tree package - Closes #5203 #5342

Merged
merged 7 commits into from
May 19, 2020
Merged

Add lisk-tree package - Closes #5203 #5342

merged 7 commits into from
May 19, 2020

Conversation

shuse2
Copy link
Collaborator

@shuse2 shuse2 commented May 18, 2020

What was the problem?

This PR resolves #5203

How was it solved?

  • Create lisk-tree package with empty interfaces

How was it tested?

  • It should build and test should pass

@shuse2 shuse2 requested review from ManuGowda and mitsuaki-u May 18, 2020 16:05
@shuse2 shuse2 self-assigned this May 18, 2020
ManuGowda
ManuGowda reviewed May 18, 2020
View reviewed changes
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file name change if suggestion accepted. Otherwise LGTM

elements/lisk-tree/src/standard_tree.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 requested a review from ManuGowda May 18, 2020 16:19
mitsuaki-u
mitsuaki-u suggested changes May 19, 2020
View reviewed changes
Copy link
Contributor

@mitsuaki-u mitsuaki-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the spelling LGTM

elements/lisk-tree/README.md

---

Copyright © 2016-2019 Lisk Foundation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2020?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be solved by #5325

elements/lisk-tree/src/index.ts Outdated Show resolved Hide resolved
elements/lisk-tree/src/index.ts Outdated Show resolved Hide resolved
elements/lisk-tree/src/markle_tree.ts Outdated Show resolved Hide resolved
elements/lisk-tree/src/markle_tree.ts Outdated Show resolved Hide resolved
elements/lisk-tree/src/verify_markle_tree.ts Outdated Show resolved Hide resolved
elements/lisk-tree/test/markle_tree.spec.ts Outdated Show resolved Hide resolved
elements/lisk-tree/test/verify_standard_tree.spec.ts Outdated Show resolved Hide resolved
@shuse2 shuse2 requested a review from mitsuaki-u May 19, 2020 09:34
@shuse2 shuse2 merged commit 8286eaa into development May 19, 2020
@shuse2 shuse2 deleted the 5203-create_tree_package branch May 19, 2020 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ManuGowda ManuGowda ManuGowda approved these changes

@mitsuaki-u mitsuaki-u mitsuaki-u approved these changes

Assignees

@shuse2 shuse2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Merkle Tree Class with interface
3 participants
@shuse2 @ManuGowda @mitsuaki-u