Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Allow custom schema in P2P constructor - Partially Closes #5419 #5434

Merged
merged 16 commits into from
Jun 16, 2020
Merged

Allow custom schema in P2P constructor - Partially Closes #5419 #5434

merged 16 commits into from
Jun 16, 2020

Conversation

ishantiw
Copy link
Contributor

What was the problem?

This PR resolves #5419

How was it solved?

  • New property to accept custom schema for peerInfo and nodeInfo
  • Construct custom schema for nodeInfo and peerinfo in framework/network

How was it tested?

Run node framework/test/test_app

@ishantiw ishantiw mentioned this pull request Jun 12, 2020
Closed
@ishantiw ishantiw self-assigned this Jun 12, 2020
@ishantiw ishantiw requested a review from shuse2 June 15, 2020 10:34
@shuse2 shuse2 requested a review from pablitovicente June 16, 2020 08:05
pablitovicente
pablitovicente reviewed Jun 16, 2020
View reviewed changes
Copy link
Contributor

@pablitovicente pablitovicente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about the place where caching of schemas happen

shuse2
shuse2 suggested changes Jun 16, 2020
View reviewed changes
Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, just one request regards to how we handle the schema object

pablitovicente
pablitovicente approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@pablitovicente pablitovicente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Shu's comment nothing to add

@ishantiw ishantiw requested a review from shuse2 June 16, 2020 15:40
@ishantiw ishantiw requested a review from shuse2 June 16, 2020 16:24
@shuse2 shuse2 merged commit 75f970c into development Jun 16, 2020
@shuse2 shuse2 deleted the 5419_redefine_p2p_message_custom_schema branch June 16, 2020 16:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pablitovicente pablitovicente pablitovicente approved these changes

@shuse2 shuse2 shuse2 approved these changes

Assignees

@ishantiw ishantiw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redefine P2P communication and message formats after using lisk-codec
3 participants
@ishantiw @pablitovicente @shuse2