This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Peers communication protocol change to WS - Closes #446 #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use prototype in peersManager - don't use acceptable in returning peers list - use self.findGoodPeers in loader - introduce updatePeerStatus function - remove setIntervals logs from peers module - fixed syntax errors - calculate consensus using random order of peers - discover new peers every 60s instead of 10s - remove peers ping function
MaciejBaj
force-pushed
the
446-ws-peers-rebased
branch
from
af4dc5d
to
d416fef
Compare
# Conflicts: # test/common/initModule.js
MaciejBaj
force-pushed
the
446-ws-peers-rebased
branch
3 times, most recently
from
37657d4
to
10ddcfd
Compare
SargeKhan
previously approved these changes
Jul 25, 2017
|
test is failing: see logs: https://jenkins.lisk.io/job/Lisk-Pipeline/job/PR-660/35/execution/node/240/log/ |
MaciejBaj
force-pushed
the
446-ws-peers-rebased
branch
from
1d20373
to
60e15f5
Compare
- fix remaining issues with other unit tests failing - correct ports switching in config.non-forge.json - recover blocks cache functional tests - fix tests after object stub removal - use ws post in accounts logic unit test
also: - remove remaining console.logs - switch http and ws ports in objectStubs
MaciejBaj
force-pushed
the
446-ws-peers-rebased
branch
from
60e15f5
to
475992d
Compare
SargeKhan
approved these changes
Jul 25, 2017
Isabello
approved these changes
Jul 25, 2017
4miners
approved these changes
Jul 26, 2017
| appName: 'lisk', | ||
| workerController: workersController.path, | ||
| perMessageDeflate: false, | ||
| secretKey: 'liskSecretKey', |
| @@ -150,7 +147,7 @@ Process.prototype.loadBlocksOffset = function (limit, offset, verify, cb) { | |||
| var params = { limit: newLimit, offset: offset || 0 }; | |||
|
|
|||
| library.logger.debug('Loading blocks offset', {limit: limit, offset: offset, verify: verify}); | |||
| // Execute in sequence via dbSequence | |||
| // Execute in sequence via dbSequence] | |||
| @@ -209,29 +206,22 @@ Process.prototype.loadBlocksOffset = function (limit, offset, verify, cb) { | |||
| * @return {Object} cb.lastValidBlock Normalized new last block | |||
| */ | |||
| Process.prototype.loadBlocksFromPeer = function (peer, cb) { | |||
| // Set current last block as last valid block | |||
There was a problem hiding this comment.
Why remove that and other comments below, they are no longer valid?
| @@ -107,7 +125,7 @@ __private.getByFilter = function (filter, cb) { | |||
| }; | |||
|
|
|||
| // Apply filters (by AND) | |||
| var peers = library.logic.peers.list(true); | |||
| var peers = library.logic.peers.list(); | |||
There was a problem hiding this comment.
Yep, but from that list API response is generated, isn't it? So API response will contain that RPC property and not contains properties that library.logic.peers.list(true); is normalizing. Please check that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change peer communication protocol from HTTP to web socket.
Implementation is close connected to newly created library - wamp-socket-cluster. Please review also changes made there.
Previous PR: #580
Closes #446