Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Unit test for signature transaction - Subtask #456 #804

Merged
merged 27 commits into from
Oct 6, 2017

Conversation

SargeKhan
Copy link
Contributor

@SargeKhan SargeKhan commented Sep 26, 2017

Adds the unit tests requested by issue: #827

Closes #827 for the parent issue #456

Usman Khan added 6 commits August 17, 2017 17:26
- Added some new tests,
- Mockes accounts module,
- Rewired private variables for testing purposes,
We'd replaced this.scope.* usages library.* usages according to #555.
This is the continuation of the same idea.
@SargeKhan SargeKhan self-assigned this Sep 26, 2017
@SargeKhan SargeKhan changed the title 456 unit test for signature transaction Unit test for signature transaction - Subtask 456 Sep 26, 2017
@SargeKhan SargeKhan changed the title Unit test for signature transaction - Subtask 456 Unit test for signature transaction - Subtask #456 Sep 26, 2017
@Isabello Isabello force-pushed the 456-unit-test-for-signature-transaction branch from 0cd51dd to 2e1c427 Compare October 5, 2017 13:20
Usman Khan added 4 commits October 5, 2017 15:45
- Added some new tests,
- Mockes accounts module,
- Rewired private variables for testing purposes,
We'd replaced this.scope.* usages library.* usages according to #555.
This is the continuation of the same idea.
@Isabello Isabello force-pushed the 456-unit-test-for-signature-transaction branch from 2e1c427 to e297d1c Compare October 5, 2017 13:45
@SargeKhan SargeKhan requested a review from a team October 5, 2017 15:10
@Isabello Isabello assigned Isabello and unassigned SargeKhan Oct 6, 2017
@Isabello Isabello merged commit 3732284 into 1.0.0 Oct 6, 2017
@Isabello Isabello deleted the 456-unit-test-for-signature-transaction branch October 25, 2017 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants