This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Unit test for dapp transaction - Subtask #456 - Closes #841 #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 1, 2017 15:31
…LiskHQ/lisk into 456-unit-test-for-dapp-transaction
…Q/lisk into 456-unit-test-for-dapp-transaction
…Q/lisk into 456-unit-test-for-dapp-transaction
Isabello
suggested changes
Oct 10, 2017
test/unit/logic/dapp.js
Outdated
| }); | ||
| }); | ||
|
|
||
| describe('when dapp link is not an actually link', function () { |
There was a problem hiding this comment.
when dapp link is not a valid url format
Isabello
changed the title
MaciejBaj
previously requested changes
Oct 12, 2017
| }); | ||
| }); | ||
|
|
||
| describe('undo', function () { |
There was a problem hiding this comment.
Please refactor the function to match current standards
test/unit/logic/dapp.js
Outdated
| }); | ||
| }); | ||
|
|
||
| describe('getBytes', function () { |
There was a problem hiding this comment.
Please refactor the function to match current standards
| }); | ||
| }); | ||
|
|
||
| describe('process', function () { |
There was a problem hiding this comment.
Please refactor the function to match current standards
Isabello
previously requested changes
Oct 12, 2017
SargeKhan
dismissed stale reviews from MaciejBaj and Isabello
Made requested changes
Isabello
approved these changes
Oct 13, 2017
MaciejBaj
approved these changes
Oct 13, 2017
LucasIsasmendi
approved these changes
Oct 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: #456
Closes child issue: #841