This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Unit test for intransfer transaction - Subtask #456 - Closes #842 #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejBaj
previously approved these changes
Oct 12, 2017
4miners
previously requested changes
Oct 12, 2017
}); | ||
}); | ||
|
||
describe('when trs.asset.inTransfer does not exist', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
property exists, but it's undefined
- globally
Isabello
previously requested changes
Oct 12, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trs should be transaction
or transactions
depending on the context
Can we extract the variables to a declarative file to reduce clutter in the tests?
Made requested changes
Isabello
previously approved these changes
Oct 13, 2017
diego-G
approved these changes
Oct 13, 2017
diego-G
previously approved these changes
Oct 13, 2017
MaciejBaj
previously approved these changes
Oct 13, 2017
bfd3450
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: #456
Closes child issue: #842