Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Unit test for intransfer transaction - Subtask #456 - Closes #842 #843

Merged
merged 13 commits into from
Oct 13, 2017

Conversation

SargeKhan
Copy link
Contributor

Parent issue: #456
Closes child issue: #842

@SargeKhan SargeKhan changed the title Unit test for dapp transaction - Subtask #456 - Closes #842 Unit test for intransfer transaction - Subtask #456 - Closes #842 Oct 11, 2017
@Isabello Isabello self-assigned this Oct 11, 2017
MaciejBaj
MaciejBaj previously approved these changes Oct 12, 2017
});
});

describe('when trs.asset.inTransfer does not exist', function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

property exists, but it's undefined - globally

Copy link
Contributor

@Isabello Isabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trs should be transaction or transactions depending on the context

Can we extract the variables to a declarative file to reduce clutter in the tests?

@SargeKhan SargeKhan dismissed stale reviews from 4miners and Isabello October 13, 2017 12:26

Made requested changes

Isabello
Isabello previously approved these changes Oct 13, 2017
@diego-G diego-G self-requested a review October 13, 2017 13:45
diego-G
diego-G previously approved these changes Oct 13, 2017
MaciejBaj
MaciejBaj previously approved these changes Oct 13, 2017
@Isabello Isabello dismissed stale reviews from MaciejBaj, diego-G, and themself via bfd3450 October 13, 2017 16:03
@Isabello Isabello merged commit 2b0564b into 1.0.0 Oct 13, 2017
@Isabello Isabello deleted the 456-unit-test-for-intransfer branch October 13, 2017 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants