This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update nodejs to 18 #8514
Merged
Update nodejs to 18 #8514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/6.0.0 #8514 +/- ##
=================================================
- Coverage 83.32% 83.32% -0.01%
=================================================
Files 593 593
Lines 22323 22323
Branches 3271 3271
=================================================
- Hits 18601 18600 -1
- Misses 3722 3723 +1 |
mosmartin
approved these changes
May 31, 2023
|
Hi @shuse2, is it prudent to update the README as well as it references node v16? |
ishantiw
approved these changes
May 31, 2023
shuse2
added a commit
that referenced
this pull request
Jun 1, 2023
* ⬆️ Update nodejs to 18 * ♻️ Update node version for action * 🐛 Update test to support node 18 connection * ♻️ Fix ws integration test * ♻️ Update README and missing type version
mitsuaki-u
pushed a commit
that referenced
this pull request
Jun 2, 2023
* ⬆️ Update nodejs to 18 * ♻️ Update node version for action * 🐛 Update test to support node 18 connection * ♻️ Fix ws integration test * ♻️ Update README and missing type version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7984
How was it solved?
How was it tested?
N/A