Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Rewrite transaction pool - Closes #561 #989

Merged
merged 90 commits into from
Nov 26, 2017
Merged

Rewrite transaction pool - Closes #561 #989

merged 90 commits into from
Nov 26, 2017

Conversation

LucasIsasmendi
Copy link
Contributor

@LucasIsasmendi LucasIsasmendi commented Nov 16, 2017 •
edited by karmacoma
Loading

Review Checklist:

Targets: Sanity, standards, docs, TODOs.

  • app.js
  • config.json
  • helpers/constants.js
  • logic/transaction.js
  • logic/transactions/pool.js
  • modules/blocks/chain.js
  • modules/blocks/process.js
  • modules/delegates.js
  • modules/loader.js
  • modules/transactions.js
  • modules/transport.js
  • test/config.json
  • test/node.js
  • test/unit/index.js
  • test/unit/logic/transactions/pool.js

LucasIsasmendi and others added 30 commits August 12, 2017 03:21
@LucasIsasmendi
Initial structure new tx pool
d7233d2
@LucasIsasmendi
Adjust descriptions
6d367b7
@LucasIsasmendi
Get by account and public key
456fac9
@LucasIsasmendi
Move tx utils to bson helper
e6248a8
@LucasIsasmendi
Eslint
4f45d33
@LucasIsasmendi
Delete array queues, getAll as entry point
24b3ed4
@LucasIsasmendi
Expire transactions worker
11793d6
@LucasIsasmendi
Adjust getAll
8176ca6
@LucasIsasmendi
Move private functions above public
6c7fbea
@LucasIsasmendi
Improve addReady, getReady test
13bd0d8
@LucasIsasmendi
Adjust getAll by address and public key
01af273
@LucasIsasmendi
check balance
8eb1dab
@LucasIsasmendi
Invalid txs list
15251a7
@LucasIsasmendi
Merge branch 'development' into 561-refactor-tx-pool
557f5b6
@LucasIsasmendi
Clear index reference, fix tx receipts balance
4c33465
@LucasIsasmendi
Count invalid txs
b55a562
@LucasIsasmendi
processPool tx type 0
83a0035
@LucasIsasmendi
No need to track deleted id txs
c743af2
@LucasIsasmendi
Check balance only from ready list
22e5a25
@LucasIsasmendi
Delete reverse option for txs list return
189ff9e
@LucasIsasmendi
Test tx type 0
165a8b2
@LucasIsasmendi
Test tx type 1
4765a21
@LucasIsasmendi
Test tx type 2
f8ddc9b
@LucasIsasmendi
Adjust test tx type 2
ddcb287
@LucasIsasmendi
Replace hardcoded test data with node.lisk calls
10b4511
@LucasIsasmendi
Test tx type 3
f0a13dd
@LucasIsasmendi
Test tx type 4 skeleton
2fab561
Test tx type 4
8a45330
Adjust data for unverified and ready
8dd701d
Multisignature sign function
50c27b0
karmacoma
karmacoma approved these changes Nov 26, 2017
View reviewed changes
Copy link
Contributor

@karmacoma karmacoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed each file to get good understanding of changes. Now ready to go into integration branch for further work.

@karmacoma karmacoma merged commit c059c9d into 972-integrate_accounts_and_pool Nov 26, 2017
@karmacoma karmacoma deleted the 561-rewrite-tx-pool branch November 26, 2017 16:26
@karmacoma karmacoma mentioned this pull request Nov 26, 2017
Closed
7 tasks
@karmacoma karmacoma mentioned this pull request Dec 21, 2017
Closed
11 tasks
shuse2 pushed a commit that referenced this pull request Apr 15, 2019
Merge pull request #990 from LiskHQ/989-remove_asset_from_base
6f653b3 
Remove asset field from base transaction - Closes #989
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Isabello Isabello Isabello requested changes

@karmacoma karmacoma karmacoma approved these changes

@4miners 4miners 4miners left review comments

Assignees

@karmacoma karmacoma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucasIsasmendi @karmacoma @Isabello @4miners