Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: L2Reward.extendDuration for expired locking positions #110

Merged
merged 3 commits into from
May 7, 2024

Conversation

has5aan
Copy link
Member

@has5aan has5aan commented May 2, 2024

Considers today as the expiry date for an expired locking position.

What was the problem?

This PR resolves #109

How was it solved?

L2Reward.extendDuration assumes today as expiry date of the locking position.

How was it tested?

Updated unit tests.

Considers today as the expiry date for an expired locking position.
@has5aan has5aan self-assigned this May 2, 2024
@has5aan has5aan requested review from gkoumout and matjazv May 2, 2024 15:42
Copy link
Contributor

@gkoumout gkoumout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, added a suggestion in the unit test

test/L2/L2Reward.t.sol Show resolved Hide resolved
@has5aan has5aan changed the title fixes: L2Reward.extendDuration for expired locking positions Fixes: L2Reward.extendDuration for expired locking positions May 7, 2024
@matjazv matjazv merged commit 93ea20e into main May 7, 2024
3 checks passed
@matjazv matjazv deleted the 109-extending-expired branch May 7, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L2Reward.extendDuration extending expired locking position
3 participants