Add possibility to pause Claim and Staking processes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matjazv
force-pushed
the
152-pause-claim-staking
branch
2 times, most recently
from
d3bcec8
to
e45885f
Compare
matjazv
force-pushed
the
152-pause-claim-staking
branch
from
e45885f
to
f0ee0f1
Compare
Phanco
approved these changes
Jun 19, 2024
gkoumout
reviewed
Jun 19, 2024
AndreasKendziorra
requested changes
Jun 20, 2024
AndreasKendziorra
approved these changes
Jun 20, 2024
matjazv
force-pushed
the
152-pause-claim-staking
branch
2 times, most recently
from
928ea6b
to
e061158
Compare
…es (#165) * Added L2VotingPowerPaused and L2GovernorPaused contract with test cases * Add deployment script * Update git submodules * Add foundry.toml * Change version function to be independent * Update comments * Update gitsubmodule, added Custom Errors * Rearrange functions according to requirements * pump forge-std to 1.8.2 * Add onReceive ERC721 and ERC1155 check * Test adjustVotingPower is unpaused * Add deployPausedDAO.sh * Add forge clean to deploy script * Clean before every forge script runs * Used `../../` to navigate paused script * rename assertInitParamsEq
…ng L2LockingPositionPaused contract
matjazv
force-pushed
the
152-pause-claim-staking
branch
from
82a214d
to
bd8ade4
Compare
gkoumout
reviewed
Jun 25, 2024
matjazv
added a commit
that referenced
this pull request
Jun 26, 2024
* Added L2VotingPowerPaused and L2GovernorPaused contract with test cases (#165) * Added L2VotingPowerPaused and L2GovernorPaused contract with test cases * Add deployment script * Update git submodules * Add foundry.toml * Change version function to be independent * Update comments * Update gitsubmodule, added Custom Errors * Rearrange functions according to requirements * pump forge-std to 1.8.2 * Add onReceive ERC721 and ERC1155 check * Test adjustVotingPower is unpaused * Add deployPausedDAO.sh * Add forge clean to deploy script * Clean before every forge script runs * Used `../../` to navigate paused script * rename assertInitParamsEq * Implement L2ClaimPaused version of L2Claim contract * Ignore unreachable warning from ERC721Upgradeable.sol because of having L2LockingPositionPaused contract * Implement paused version of Staking process * Remove unneeded L2StakingPaused contract * Add deploy shell script for paused Staking process * Add deploy shell script for paused Claim process * Add unit tests for paused version of contracts * Fix deployment shell scripts * Remove unneeded L2StakingPaused address * Remove warnings because of forge-std upgrade * Remove fixed version of Foundry from pr.yaml * Add additional paused functions for Reward contract * Modify deployment script to pause DAO and Staking functionalities at the same time * Remove unneeded imports from pausable versions of contracts * Remove deploying DAO when deploying Staking process * Fix two unit tests * Remove unneeded blank spaces * Fix unit test for L2RewardPaused --------- Co-authored-by: Franco NG <franco.ng@lightcurve.io>
shuse2
pushed a commit
that referenced
this pull request
Jun 26, 2024
* Added L2VotingPowerPaused and L2GovernorPaused contract with test cases (#165) * Added L2VotingPowerPaused and L2GovernorPaused contract with test cases * Add deployment script * Update git submodules * Add foundry.toml * Change version function to be independent * Update comments * Update gitsubmodule, added Custom Errors * Rearrange functions according to requirements * pump forge-std to 1.8.2 * Add onReceive ERC721 and ERC1155 check * Test adjustVotingPower is unpaused * Add deployPausedDAO.sh * Add forge clean to deploy script * Clean before every forge script runs * Used `../../` to navigate paused script * rename assertInitParamsEq * Implement L2ClaimPaused version of L2Claim contract * Ignore unreachable warning from ERC721Upgradeable.sol because of having L2LockingPositionPaused contract * Implement paused version of Staking process * Remove unneeded L2StakingPaused contract * Add deploy shell script for paused Staking process * Add deploy shell script for paused Claim process * Add unit tests for paused version of contracts * Fix deployment shell scripts * Remove unneeded L2StakingPaused address * Remove warnings because of forge-std upgrade * Remove fixed version of Foundry from pr.yaml * Add additional paused functions for Reward contract * Modify deployment script to pause DAO and Staking functionalities at the same time * Remove unneeded imports from pausable versions of contracts * Remove deploying DAO when deploying Staking process * Fix two unit tests * Remove unneeded blank spaces * Fix unit test for L2RewardPaused --------- Co-authored-by: Franco NG <franco.ng@lightcurve.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #152.
How was it solved?
L2ClaimPaused,L2LockingPositionPausedandL2RewardPausedHow was it tested?