Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing suite #181

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Improve testing suite #181

merged 4 commits into from
Jun 25, 2024

Conversation

Phanco
Copy link
Member

@Phanco Phanco commented Jun 21, 2024

What was the problem?

This PR resolves #102

How was it solved?

  1. Relocated L2Claim setup to L2ClaimHelper
  2. Added Invariant test for L1LiskToken, L2LiskToken, L2Claim
  • L1LiskToken
    • Run: Arbitrary number of burnFrom operations
    • Assert: metadata unchanged, sum of balances = totalSupply()
  • L2LiskToken
    • Run: Arbitrary number of mint and burn operations
    • Assert: metadata unchanged, sum of balances = totalSupply()
  • L2Claim
    • Run: Arbitrary number of claimRegularAccount and claimMultisigAccount
    • Assert: metadata unchanged, amount out = amount reduced

How was it tested?

Newly added test cases passed

@Phanco Phanco changed the base branch from development to feature/improvements-and-recommendations June 21, 2024 11:34
@Phanco Phanco changed the base branch from feature/improvements-and-recommendations to development June 21, 2024 11:39
@Phanco Phanco self-assigned this Jun 21, 2024
@Phanco Phanco requested review from matjazv and has5aan June 21, 2024 14:13
@Phanco Phanco marked this pull request as ready for review June 21, 2024 14:13
test/L2/L2Claim.t.sol Outdated Show resolved Hide resolved
@matjazv matjazv merged commit 74a0da4 into development Jun 25, 2024
4 checks passed
@matjazv matjazv deleted the 102-improve-testing-suite branch June 25, 2024 14:53
matjazv added a commit that referenced this pull request Jun 26, 2024
* Add Invariant Tests

* Updated invariant testings

* Update format

* Update test/L2/L2Claim.t.sol

Co-authored-by: Matjaz Verbole <verbole@gmail.com>

---------

Co-authored-by: Matjaz Verbole <verbole@gmail.com>
shuse2 pushed a commit that referenced this pull request Jun 26, 2024
* Add Invariant Tests

* Updated invariant testings

* Update format

* Update test/L2/L2Claim.t.sol

Co-authored-by: Matjaz Verbole <verbole@gmail.com>

---------

Co-authored-by: Matjaz Verbole <verbole@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the testing suite
3 participants