Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic versioning is used in upgradable contracts #28

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

matjazv
Copy link
Contributor

@matjazv matjazv commented Jan 15, 2024

What was the problem?

This PR resolves #23.

How was it solved?

  • ISemver interface was used in currently upgradable contract - Claim contract.
  • This interface supports version() function which may be called by 3rd party web3 applications to check to which version of smart contract are they communicate with.

How was it tested?

  • New unit tests were implemented.
  • Old and new unit tests passed.

@matjazv matjazv self-assigned this Jan 15, 2024
@Phanco Phanco self-requested a review January 15, 2024 13:09
@Phanco
Copy link
Member

Phanco commented Jan 16, 2024

Other parts look good 👍

@matjazv matjazv force-pushed the 23-semver-upgradable-contracts branch from 83a5f09 to 6b7c954 Compare January 16, 2024 10:50
@shuse2 shuse2 merged commit d2beac6 into main Jan 17, 2024
3 checks passed
@shuse2 shuse2 deleted the 23-semver-upgradable-contracts branch January 17, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SemVer in upgradable smart contracts
4 participants