-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwapAndBridge feature #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Just some minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just few small comments left.
Two other things to consider:
|
…s in constructor, and add slippage check
…s in constructor, and add slippage check
v0.0.180
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment left.
Well done!
Co-authored-by: Matjaz Verbole <verbole@gmail.com>
…cts into feature/swapAndBridge
Closes #191.
Implement swap-and-bridge feature with the
SwapAndBridge
contract. This contract exposes theswapAndBridgeToWithMinimumAmount
public function by which users can swap ETH for a target LST and bridge it directly to an L2 while also specifying the minimum amount of LST to receive. The contract also exposes some convenience functions and a receive fallback allowing the interaction to happen just by sending ETH to the contract.A new
SwapAndBridge
contract should be deployed for each LST protocol and target L2. The contract will be created with the L1 LST token, the L1 bridge, and the target L2 token as parameters. In this PR we add integration tests for Lido and Diva LST protocols as examples.